Sergey Gotliv has posted comments on this change. Change subject: core: Removing targetSnapshot parameter ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24055/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java: Line 399: !validate(storageValidator.allDomainsWithinThresholds()) || Line 400: !performImagesChecks() || Line 401: !validate(vmValidator.vmDown()) || Line 402: // if the user choose to commit a snapshot - the vm cant have disk snapshots attached to other vms. Line 403: (getSnapshotDao().get(getParameters().getDstSnapshotId()).getType() == SnapshotType.REGULAR && !validate(vmValidator.vmNotHavingDeviceSnapshotsAttachedToOtherVms(false)))) { > the appropiate fix here is to load the snapshot before the use of the snaps I agree with Liron. Actually I gave a similar comment in another patch for that subject. Line 404: return false; Line 405: } Line 406: Line 407: Snapshot snapshot = getSnapshotDao().get(getSnapshotId()); -- To view, visit http://gerrit.ovirt.org/24055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d95947d52180720d98f5d07dcacc13e17161f5e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
