Juan Hernandez has posted comments on this change.
Change subject: core: [rmd] DoubleCompat RefObject removal
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DoubleCompat.java
Line 11: // eat it and return null
Swallowing exceptions without leaving trace is not very good practice from my
point of view. Why not send here the exception to the log? Something like:
log.warn("The value \"" + value + "\" is not a valid decimal number, will
return null.", e)
Line 20: // eat it and return null
Same here.
--
To view, visit http://gerrit.ovirt.org/4235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7068aee17b1b763479b4381b7806809e13117247
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
