Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Move logs out of /usr ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23794/3/packaging/setup/dbutils/common.sh File packaging/setup/dbutils/common.sh: Line 6: PORT="5432" Line 7: DATABASE="engine" Line 8: USERNAME="engine" Line 9: VERBOSE=false Line 10: LOGDIR="/var/log/ovirt-engine" > does non root usage work? Naturally, if /var/log/ovirt-engine does not exist, or if user has write permissions there (both are reasonable in a dev env imo). Anyway, already pushed an update to write by default to /tmp. Note that this change also makes the two scripts that are actually called by setup to write to its own log file, so unless there is some complex flow I did not test, the change here (common.sh) does not apply in most normal cases. Line 11: if [ -d ${LOGDIR} ]; then Line 12: LOGFILE="${LOGDIR}/$ME.log" Line 13: else Line 14: LOGFILE="$ME.log" -- To view, visit http://gerrit.ovirt.org/23794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1391b11225e69c98ff843d13db7ef517ec6534b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
