Juan Hernandez has posted comments on this change.
Change subject: core: [rmd] remove Refobject from MacPoolManager
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 61: @SuppressWarnings("serial")
Why not add the serialId field instead of supressing the warning?
Line 588: void AddVmDynamic() {
Are you making this method more public on purpose?
Line 600: void AddVmStatistics() {
Are you making this method more public on purpose?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java
Line 25:
You could also remove the redundant mLockObj, just using synchronized in the
relevant methods.
Using "List" instead of "java.util.ArrayList" (or maybe Queue).
There is no need to have the class name and the method name in log messages.
But I guess that these can be part of a different cleanup :-)
--
To view, visit http://gerrit.ovirt.org/4236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3056e7fb33f4a2fafe223b58d985ef65c855acc8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
