Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: fix loading animation. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23951/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java: Line 90 Line 91 Line 92 Line 93 Line 94 > will we still see the loading indicator if the tab was already visited? Yes the loading animation will now show whenever the query is sent to the back and the isFirstQuery flag is set to true (which happens when you switch tabs, click refresh, etc). I removed this because it is no longer necessary. Feel free to apply this patch and check for yourself, more verifies are always better. -- To view, visit http://gerrit.ovirt.org/23951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834253f33ae965eacd058f77f720035f45ec6f02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
