Eli Mesika has posted comments on this change.

Change subject: core: Fix admin@internal permissions
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24107/1/packaging/dbscripts/insert_predefined_roles.sql
File packaging/dbscripts/insert_predefined_roles.sql:

Line 348: INSERT INTO 
roles(id,name,description,is_readonly,role_type,allows_viewing_children) SELECT 
v_VM_ADMIN_ID,'UserVmManager','User Role, with permission for any operation on 
Vms',true,2,true;
Line 349: 
Line 350: -- insert local admin user to users table and assign superuser 
permissions
Line 351: INSERT INTO 
users(user_id,name,domain,username,groups,status,last_admin_check_status)
Line 352:         SELECT v_LOCAL_ADMIN_ID, 'admin', 'internal', 
'admin@internal','',1,true;
Martin, this solves only the clean install scenario 
Please revert this code and to that as an upgrade script with UPDATE command on 
the relevant record
Line 353: 
Line 354: INSERT INTO 
permissions(id,role_id,ad_element_id,object_id,object_type_id)
Line 355:         SELECT uuid_generate_v1(), v_SUPER_USER_ID, v_LOCAL_ADMIN_ID, 
getGlobalIds('system'), 1;
Line 356: 


-- 
To view, visit http://gerrit.ovirt.org/24107
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacc197cbff33d74cf8f2d7bd1b18c31092fdea43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to