Liron Ar has posted comments on this change. Change subject: core: Add a validation when deactivate ISO domain. ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/20331/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java: Line 151: if (getVmDynamicDAO().get(vmStatic.getId()).getStatus() != VMStatus.Down Line 152: && VmDeviceUtils.isVMHasAttachedISO(vmStatic.getId())) { Line 153: vmNames.add(vmStatic.getName()); Line 154: } Line 155: } > 1. I don't see it that way 1. what don't you see that way? please respond to the comment with reasoning..that's general statement that doesn't respond to any of the arguments that i made. 2. possibly we need more opinions on that..i tend to agree that we might need a complete solution to that in another patch. Line 156: return vmNames; Line 157: } Line 158: Line 159: /** -- To view, visit http://gerrit.ovirt.org/20331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
