Yaniv Dary has posted comments on this change. Change subject: packaging: build: move to ant drop maven and jboss modules ......................................................................
Patch Set 3: (5 comments) http://gerrit.ovirt.org/#/c/24142/3/build.xml File build.xml: Line 38: Line 39: <target name="dependencies.dep-java-config" if="depmode.java-config"> Line 40: <dep-java-config package="commons-collections"/> Line 41: <dep-java-config package="dom4j" id="dom4j-1"/> Line 42: <dep-java-config package="postgresql-jdbc" id="jdbc-postgresql"/> This is not a build time dependency, why is this here? Line 43: </target> Line 44: Line 45: <target name="dependencies.dep-build-classpath" if="depmode.build-classpath"> Line 46: <dep-build-classpath package="commons-collections"/> Line 44: Line 45: <target name="dependencies.dep-build-classpath" if="depmode.build-classpath"> Line 46: <dep-build-classpath package="commons-collections"/> Line 47: <dep-build-classpath package="dom4j"/> Line 48: <dep-build-classpath package="postgresql-jdbc"/> also. Line 49: </target> Line 50: Line 51: <target name="dependencies" depends=" Line 52: dependencies.dep-java-config, http://gerrit.ovirt.org/#/c/24142/3/ovirt-engine-dwh.spec.in File ovirt-engine-dwh.spec.in: Line 24: %if 0%{?rhel} Line 25: %global ovirt_install_systemd 0 Line 26: %global ovirt_install_systemv 1 Line 27: %global commons_collections commons-collections Line 28: %global dom4j dom4j-eap6 We do have dom4j in rhel to my understanding. Why are you using dom4j-eap6? Line 29: %endif Line 30: Line 31: %global product_name Data warehouse package for oVirt Virtualization Suite Line 32: %global product_description oVirt virtualization manager data warehouse Line 128: Line 129: cat > build.properties << __EOF__ Line 130: dependencies.commons-collections = $(build-classpath %{commons_collections}) Line 131: dependencies.dom4j = $(build-classpath %{dom4j}) Line 132: dependencies.postgresql-jdbc = $(build-classpath postgresql-jdbc) What are you doing here? Line 133: __EOF__ Line 134: Line 135: %build Line 136: make %{make_common_opts} Line 186: %if 0%{?rhel} Line 187: dom4j-1.6.1.redhat-6-sources.jar dom4j-eap6/dom4j-1.6.1.redhat-6-sources.jar Line 188: dom4j-1.6.1.redhat-6.jar dom4j-eap6/dom4j-1.6.1.redhat-6.jar Line 189: %else Line 190: dom4j.jar same question Line 191: %endif Line 192: postgresql-jdbc.jar Line 193: __EOF__ Line 194: -- To view, visit http://gerrit.ovirt.org/24142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39550f694d7e8c37bbe189c1b9bfd944a5dad2e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
