Martin Peřina has posted comments on this change. Change subject: core: fix useDnsLookup behavior ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24189/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 724: if (args.contains(ARG_LDAP_SERVERS)) { Line 725: krbConfCreator = new KrbConfCreator(gssapiDomainsString, useDnsLookup, ldapServersPerGSSAPIDomains); Line 726: } else { Line 727: krbConfCreator = new KrbConfCreator(gssapiDomainsString, useDnsLookup, Collections.EMPTY_MAP); Line 728: } > You meant of course if (!args.contains(ARG_LDAP_SERVERS)) { Sure :-) Line 729: StringBuffer buffer = null; Line 730: buffer = krbConfCreator.parse("y"); Line 731: krbConfCreator.toFile(utilityConfiguration.getkrb5confFilePath() + TESTING_KRB5_CONF_SUFFIX, buffer); Line 732: log.info("Successfully created kerberos configuration for domain(s): " + gssapiDomainsString); -- To view, visit http://gerrit.ovirt.org/24189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
