Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: Prevent snapshot in ppc64 ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/21658/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java: Line 52: Line 53: private boolean memorySnapshotSupported; Line 54: Line 55: public boolean isMemorySnapshotSupported() { Line 56: return memorySnapshotSupported; why not just do return getModel().isMemorySnapshotSupported() Then you don't have to do any of the other changes. as you get the value directly from the model. Line 57: } Line 58: Line 59: private void setMemorySnapshotSupported(boolean value) { Line 60: if (memorySnapshotSupported != value) { -- To view, visit http://gerrit.ovirt.org/21658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I148f0a9356086b31e66d4f5dd6eab6afc642cada Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: liron aravot <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
