Omer Frenkel has posted comments on this change. Change subject: core: Load VM disks before updating ......................................................................
Patch Set 2: since updateVm doesnt update disks, but only vm configuration i think a better solution would be to make diskList member as @Editable instead of loading the disks just for that. its not the best approach i guess, but this is how its handled for other members like this (interfaces) so i prefer to use the same method. -- To view, visit http://gerrit.ovirt.org/24060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
