Martin Peřina has posted comments on this change. Change subject: core: fix useDnsLookup behavior ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24190/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 768: log.info("Creating kerberos configuration for domain(s): " + gssapiDomainsString); Line 769: useDnsLookup = utilityConfiguration.getUseDnsLookup(); Line 770: if (!ldapServers && useDnsLookup) { Line 771: // The arguments do not contain a list of ldap servers, the 725 Line 772: // kerberos configuration should not be created according to it if 726 > please remove the trailing numbers (725, 726) I fixed this in 23996, which is waiting to be merged Line 773: // useDnsLookup is set to true as in this case the kdc and the domain_realm info Line 774: ldapServersPerGSSAPIDomains = Collections.emptyMap(); Line 775: } Line 776: krbConfCreator = new KrbConfCreator(gssapiDomainsString, useDnsLookup, ldapServersPerGSSAPIDomains); -- To view, visit http://gerrit.ovirt.org/24190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic96e2f9fafcac1e6ba952a198bfb9cecc160ba8b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
