Juan Hernandez has uploaded a new change for review.

Change subject: core: Make VM disks editable
......................................................................

core: Make VM disks editable

When a VM is updated the data from the database is compared to the
updated VM object provided by the caller. But the VM object loaded from
the database doesn't contain the list of disks, so if the caller
provides an VM object that contains the list of disks the UpdateVM
command will wrongly assume that the caller is trying to modify this
list. To avoid this issue this patch marks the list of disks as
editable, so that the UpdateVM command will ignore it.

Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600
Bug-Url: https://bugzilla.redhat.com/1059713
Signed-off-by: Juan Hernandez <[email protected]>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/24312/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
index 33add3a..b1ada38 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
@@ -39,6 +39,7 @@
     @EditableField
     private List<VmNetworkInterface> interfaces;
 
+    @EditableField
     private ArrayList<DiskImage> diskList;
     private Map<Guid, VmDevice> managedDeviceMap;
     private List<VmDevice> unmanagedDeviceList;


-- 
To view, visit http://gerrit.ovirt.org/24312
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fa0a0397a44adc93680eae593a92346f9e67600
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to