Liron Ar has posted comments on this change. Change subject: core: Support detach Storage Domain with disks. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24286/1/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 999: END; $procedure$ Line 1000: LANGUAGE plpgsql; Line 1001: Line 1002: Line 1003: Create or replace FUNCTION getAllVMsWithDisksOnOtherStorageDomain(v_storage_domain_id UUID) RETURNS SETOF GetNamesOfVmStatic_rs > @Tal, will change to return vms as an entity 1. if you only consider disks that are part of the ovf, shareable disks should be excluded here as well. 2. i suggested an implementation way that should be better, why don't you agree with it? 3. why do we care if the disk is contained in the ovf or not? the purpose here is to say that those vms won't be able to run as they used to after importing the domain. Line 1004: AS $procedure$ Line 1005: BEGIN Line 1006: RETURN QUERY SELECT DISTINCT vm_static.vm_name Line 1007: FROM vm_static -- To view, visit http://gerrit.ovirt.org/24286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I971fe6acd4a2667a09487c5e1108cf7c759587f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
