Michael Pasternak has posted comments on this change. Change subject: codegen, sdk: Use Nothing instead of None ......................................................................
Patch Set 1: Code-Review-1 Juan, - while i understand the motivation behind this, it's too artificial, it's like creating a replacement for NULL in Java, while it was initially designed to specify that parameter has no value, - no Python developer will understand this, i think it should be always send as is and server (REST-API) should be capable of handling HTTP headers and URL params with no value attached, otherwise you will have to do the same in all clients, and you have *no* control over *all* clients ... - also it will not work as in most IDEs supporting auto-completion when completing method, it created along with default values [1], so i'm sure users have defaults as None in the code even if they not tend to have it. [1] vm.start(action=action, correlation_id=None) -- To view, visit http://gerrit.ovirt.org/24305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2798a49da133a3c378dcaecd8275702e05c82acb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
