Liron Ar has posted comments on this change. Change subject: core, restapi: provide capabillity to get vm ovf config ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/24287/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfHelper.java: Line 56: return vm; Line 57: } Line 58: Line 59: public String generateOvfConfigurationForVm(VM vm) { Line 60: if (VMStatus.ImageLocked != vm.getStatus()) { > consider early return if status is ImageLocked I agree, i'll change it as part of this change - http://gerrit.ovirt.org/24288 which performs further refactors to that code, in this patch its only copy-paste. Line 61: VmHandler.updateDisksFromDb(vm); Line 62: DiskImagesValidator validator = new DiskImagesValidator(vm.getDiskList()); Line 63: if (validator.diskImagesNotLocked().isValid()) { Line 64: loadVmData(vm); -- To view, visit http://gerrit.ovirt.org/24287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cbcd666519ffd138fd3efd4e130495529eaec0f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
