Yair Zaslavsky has posted comments on this change.

Change subject: core: Upgrade db from 3.0 to 3.1 fails due to missing 
supported_engines
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/custom.sql
Line 19: select 
fn_db_add_column('vds_dynamic','supported_engines','varchar(40)');
Why not using upgrade script?
You have many examples under the upgrade directory for how to do that.
For example - 03_01_1080_add_allow_snapshot.sql

--
To view, visit http://gerrit.ovirt.org/4177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59044a41f6f328daa613e36b5ce5dfb027b52c8f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to