Omer Frenkel has posted comments on this change.
Change subject: engine: Replace gluster Volume Brick Start
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
Line 266: GlusterVolumeRemoveBricks(1406,
ActionGroup.MANIPULATE_GLUSTER_VOLUME),
1406 already in use (above)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 73:
mSeverities.put(AuditLogType.GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED,
AuditLogSeverity.ERROR);
what about:
GLUSTER_VOLUME_REMOVE_BRICKS(4014),
GLUSTER_VOLUME_REMOVE_BRICKS_FAILED(4015),
?
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 722: ACTION_TYPE_FAILED_NOT_A_GLUSTER_VOLUME_BRICK=Cannot ${action}
${type}. Replacing brick is not a Gluster volume brick.
what about other messages added in this patch?
ACTION_TYPE_FAILED_GLUSTER_VOLUME_IS_DOWN
ACTION_TYPE_FAILED_CAN_NOT_REMOVE_ALL_BRICKS_FROM_VOLUME
VAR__TYPE__GLUSTER_VOLUME_BRICK,
and please remove this whitespace
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 515: GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED=Could not start Gluster
Volume ${glusterVolumeName} Replace Brick.
missing here as well and please remove whitespaces
--
To view, visit http://gerrit.ovirt.org/4440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c16d8bfce403307968c3b6d77395bd0b25daee
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
