Ravi Nori has uploaded a new change for review. Change subject: restapi : Handle empty int values in JAX-B parser ......................................................................
restapi : Handle empty int values in JAX-B parser JAX-B replacement IntegerParser should handle empty values for integer fields. Set the default value to 0. Change-Id: I3823d8894f316d78f753034fdbd89a79f480516e Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/24401/1 diff --git a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java index f9c5d4d..195ce14 100644 --- a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java +++ b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/IntegerParser.java @@ -15,6 +15,9 @@ private static final BigInteger MAX_UNSIGNED_INT = new BigInteger("4294967295"); // 2^32-1 public static short parseShort(String value) { + if (value.trim().equals("")) { + value = "0"; + } BigInteger result = DatatypeConverter.parseInteger(value); if (result.compareTo(MAX_SHORT) > 0) { throw new InvalidValueException("Value " + value + " is greater than the maximum short " + MAX_SHORT); @@ -23,6 +26,9 @@ } public static int parseUnsignedShort(String value) { + if (value.trim().equals("")) { + value = "0"; + } BigInteger result = DatatypeConverter.parseInteger(value); if (result.compareTo(MAX_UNSIGNED_SHORT) > 0) { throw new InvalidValueException("Value " + value + " is greater than maximum unsigned short " + MAX_UNSIGNED_SHORT); @@ -31,6 +37,9 @@ } public static int parseInt(String value) { + if (value.trim().equals("")) { + value = "0"; + } BigInteger result = DatatypeConverter.parseInteger(value); if (result.compareTo(MAX_INT) > 0) { throw new InvalidValueException("Value " + value + " is greater than maximum integer " + MAX_INT); @@ -39,6 +48,9 @@ } public static long parseUnsignedInt(String value) { + if (value.trim().equals("")) { + value = "0"; + } BigInteger result = DatatypeConverter.parseInteger(value); if (result.compareTo(MAX_UNSIGNED_INT) > 0) { throw new InvalidValueException("Value " + value + " is greater than maximum unsigned integer " + MAX_UNSIGNED_INT); -- To view, visit http://gerrit.ovirt.org/24401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3823d8894f316d78f753034fdbd89a79f480516e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
