Alissa Bonas has posted comments on this change. Change subject: engine : creating storage connection with empty port, port is set to 0 ......................................................................
Patch Set 3: I recommend to put this validation logic once in a common place and reuse it in Add/Update commands. Something like StorageServerConnectionCommandBase can be a good place. I don't understand your question: "Is it preferred to send default port for add/update command if the value is 0?" You mean if to send it at all? I assume we'd like to prevent a case where the server will try to connect to port 0 if it was mistakenly added to the system. -- To view, visit http://gerrit.ovirt.org/24402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief68a9b65946d88e3eace6f21fc887ea373725b1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Cheryn Tan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
