Antoni Segura Puimedon has posted comments on this change. Change subject: engine_page: use vdsm to detect mgmt interface ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24417/4/src/engine_page.py File src/engine_page.py: Line 48: networks = netinfo.networks() Line 49: Line 50: mgmtIface = [] Line 51: for net in networks: Line 52: if 'ovirtmgmt' in net or 'rhevm' in net: It should be: if net in ('ovirtmgmt', 'rhevm'): Otherwise a network like 'dovirtmgmt' or 'rhevmaaa' would match. Line 53: if 'bridge' in networks[net]: Line 54: mgmtIface = [networks[net]['bridge']] Line 55: else: Line 56: mgmtIface = [networks[net]['iface']] -- To view, visit http://gerrit.ovirt.org/24417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e1b69c0f465f1e38779e451777cae67bd4cde40 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Joey Boggs <jbo...@redhat.com> Gerrit-Reviewer: Ryan Barry <rba...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
