Eli Mesika has posted comments on this change. Change subject: tools: Sort domains when validating in engine-manage-domains ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24450/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java: Line 778: String ldapServerPort, Line 779: boolean isValidate, Line 780: List<String> ldapServers) throws ManageDomainsResult { Line 781: Line 782: List<Entry<String, String>> gssapiDomainValues = new ArrayList<>(gssapiDomains.getValues()); Why not encapsulate this in a method since it repeats below ? Line 783: if (isValidate) { Line 784: // sort domains so validate report looks better Line 785: Collections.sort(gssapiDomainValues, createDomainComparator()); Line 786: } -- To view, visit http://gerrit.ovirt.org/24450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6243fb8d6ae1fc34c31517559bb56b091cc10b1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
