Vojtech Szocs has posted comments on this change. Change subject: webadmin: Add host via Guide-Me doesn't work (#818182) ......................................................................
Patch Set 1: >From infrastructure perspective, confirm dialog handling is not consistent >between TabModelProvider and AbstractModelBoundPopupPresenterWidget: - TabModelProvider subclasses don't need to override getConfirmModelPopup() to reveal DefaultConfirmationPopupPresenterWidget - AbstractModelBoundPopupPresenterWidget subclasses must override getConfirmModelPopup(), as super implementation is no-op This will be addressed in future patch, where default confirm dialog handling logic will be moved to ModelBoundPopupHandler. -- To view, visit http://gerrit.ovirt.org/4445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4364c6d7edd51b63166dc0a4a90a40022c6d71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
