Sahina Bose has posted comments on this change.

Change subject: gluster: fix NPE in volume sync job
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24430/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java:

Line 169: 
Line 170:         VdsStatic server = dbUtils.getServer(clusterId, hostnameOrIp);
Line 171:         if (server == null) {
Line 172:             log.warnFormat("Could not add brick {0} to volume {1} - 
server {2} not found in cluster {3}", brickInfo, volumeId, hostnameOrIp, 
clusterId);
Line 173:             return getBrickEntity(clusterId, volumeId, brickOrder, 
null, brickDir);
Please handle null server in GlusterCoreUtils
Line 174:         }
Line 175: 
Line 176:         return getBrickEntity(clusterId, volumeId, brickOrder, 
server, brickDir);
Line 177:     }


-- 
To view, visit http://gerrit.ovirt.org/24430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I063569a3452a5c898a5a16791aff9ad409caf1cc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to