Juan Hernandez has posted comments on this change. Change subject: webadmin: Fix Java 7 compilation issues ......................................................................
Patch Set 3: > Thanks Juan, EntityModelTextColumn was indeed used with wrong type parameter > on multiple places (EntityModelEnumColumn should be fine though). I'm just > wondering why this worked when building with JRE 6 at all.. I wonder that as well. Maybe a bug in the Java 6 compiler :-) . > why did you change CXFContextInterceptor? (causes compile error for me..) That shouldn't have gone into the patch. Is something needed to build with the jboss-as in Fedora 17 that got mixed by accicent. > why did you change GwtDynamicHostPageServlet? (removing character encoding > statement) Another thing that shouln't have gone into the patch. By the way, I have a separate patch for that, in case you want to take a look: http://gerrit.ovirt.org/4314 I am generating a new patch set fixing this mistakes. -- To view, visit http://gerrit.ovirt.org/4315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f1b74f3b84019b8ba28a2cefaef42db25f39f89 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
