Liron Ar has posted comments on this change. Change subject: core: modify log message on live snapshot failure ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24383/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 382: } Line 383: } Line 384: Line 385: private void handleVdsLiveSnapshotFailure(VdcBLLException e) { Line 386: log.warnFormat("Could not live snapshot due to error: {0}. VM will still be configured to the new created snapshot", i'd add "perform" Line 387: ExceptionUtils.getMessage(e)); Line 388: addCustomValue("SnapshotName", getSnapshotName()); Line 389: addCustomValue("VmName", getVmName()); Line 390: updateCallStackFromThrowable(e); -- To view, visit http://gerrit.ovirt.org/24383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee77b46be0948ab90de2e9ea438ef9e9b4413546 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
