Gilad Chaplik has posted comments on this change.

Change subject: backend, db: store additional hosted engine info
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/23530/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java:

Line 45:                     .getObject("ksm_cpu_percent"));
Line 46:             entity.setksm_pages(rs.getLong("ksm_pages"));
Line 47:             entity.setksm_state((Boolean) rs.getObject("ksm_state"));
Line 48:             
entity.setAnonymousHugePages(rs.getInt("anonymous_hugepages"));
Line 49:             entity.setHighlyAvailableScore(rs.getInt("ha_score"));
just for general knowledge, dealing with ha_score in this patch is a separate 
bug, right?
Line 50:             
entity.setHighlyAvailableIsConfigured(rs.getBoolean("ha_configured"));
Line 51:             
entity.setHighlyAvailableIsActive(rs.getBoolean("ha_active"));
Line 52:             
entity.setHighlyAvailableGlobalMaintenance(rs.getBoolean("ha_global_maintenance"));
Line 53:             
entity.setHighlyAvailableLocalMaintenance(rs.getBoolean("ha_local_maintenance"));


-- 
To view, visit http://gerrit.ovirt.org/23530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to