Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Adding virt service checkbox in Cluster dialog
......................................................................
Patch Set 2: (2 inline comments)
besides the 2 comments in constants.java:
in edit cluster dialog, if the cluster contains VMs, the 'support virt'
checkbox should be checked & disabled.
you can use the search mechanism VMs: cluster = XXX.
make sure that the backend has this validation too (hint: currently they don't
:) )
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 277:
remove \t
Line 1317: @DefaultStringValue("Atlease one service should be selected")
you mean 'At least'
--
To view, visit http://gerrit.ovirt.org/4387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I591034e4c26cb881b763a206870cff8b254abe95
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
