Greg Padgett has posted comments on this change. Change subject: backend, db: store additional hosted engine info ......................................................................
Patch Set 4: (3 comments) Thanks for the reviews. Master patch is at http://gerrit.ovirt.org/#/c/20018/. @Eli - patch renamed (used 03_05 prefix in master) @Martin - there was some discussion of vdsDynamic vs vdsStatistics in http://gerrit.ovirt.org/#/c/20018/. The values can change while the vds is 'up', which led to the use of vdsStatistics for its more frequent sampling/updates. http://gerrit.ovirt.org/#/c/23530/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 587: public void setHighlyAvailableGlobalMaintenance(Boolean value) { Line 588: this.mVdsStatistics.setHighlyAvailableGlobalMaintenance(value); Line 589: } Line 590: Line 591: public Boolean getHighlyAvailableLocalMaintenance() { > is there a special reason to use wrapped classes? No need for them, done. Line 592: return this.mVdsStatistics.getHighlyAvailableLocalMaintenance(); Line 593: } Line 594: Line 595: public void setHighlyAvailableLocalMaintenance(Boolean value) { http://gerrit.ovirt.org/#/c/23530/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java: Line 28: // Score 0 means no HA agents are on this host Line 29: // Positive score means there is an agent Line 30: private Integer highlyAvailableScore; Line 31: private int anonymousHugePages; Line 32: private Boolean highlyAvailableIsConfigured; > I would prefer more verbose documentation. Expected value is obvious here, Done, let me know if it's not what you wanted :) Line 33: private Boolean highlyAvailableIsActive; Line 34: private Boolean highlyAvailableGlobalMaintenance; Line 35: private Boolean highlyAvailableLocalMaintenance; Line 36: http://gerrit.ovirt.org/#/c/23530/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java: Line 45: .getObject("ksm_cpu_percent")); Line 46: entity.setksm_pages(rs.getLong("ksm_pages")); Line 47: entity.setksm_state((Boolean) rs.getObject("ksm_state")); Line 48: entity.setAnonymousHugePages(rs.getInt("anonymous_hugepages")); Line 49: entity.setHighlyAvailableScore(rs.getInt("ha_score")); > please ignore this comment, got confused :) Done :) Line 50: entity.setHighlyAvailableIsConfigured(rs.getBoolean("ha_configured")); Line 51: entity.setHighlyAvailableIsActive(rs.getBoolean("ha_active")); Line 52: entity.setHighlyAvailableGlobalMaintenance(rs.getBoolean("ha_global_maintenance")); Line 53: entity.setHighlyAvailableLocalMaintenance(rs.getBoolean("ha_local_maintenance")); -- To view, visit http://gerrit.ovirt.org/23530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62849ffe0f7392c1feb1f2a0536a23410b58210 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
