Maor Lipchuk has uploaded a new change for review. Change subject: core: Use parameter instead fetching again from DB. ......................................................................
core: Use parameter instead fetching again from DB. Use vmDynamic parameter which already fetched from the DB, instead fetching the VM dynamic again from the DB. Signed-off-by: Maor Lipchuk <[email protected]> Change-Id: I38eae06b8710136371c91f0d3b7739f58fc2792d --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/24616/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java index 58f756d..a765299 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java @@ -156,7 +156,7 @@ List<String> vmNames = new LinkedList<>(); for (VmStatic vmStatic : vms) { VmDynamic vmDynamic = getVmDynamicDAO().get(vmStatic.getId()); - if (getVmDynamicDAO().get(vmStatic.getId()).getStatus() != VMStatus.Down + if (vmDynamic.getStatus() != VMStatus.Down && !StringUtils.isEmpty(vmDynamic.getCurrentCd() != null ? vmDynamic.getCurrentCd() : vmStatic.getIsoPath())) { vmNames.add(vmStatic.getName()); -- To view, visit http://gerrit.ovirt.org/24616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I38eae06b8710136371c91f0d3b7739f58fc2792d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
