Martin Sivák has posted comments on this change. Change subject: engine: Numa feature ......................................................................
Patch Set 6: (4 comments) That is much better, just some minor comments. http://gerrit.ovirt.org/#/c/23702/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNode.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNode.java: Line 1: package org.ovirt.engine.core.common.businessentities; Please clean up the line breaks in this file to use LF only. Line 2: Line 3: import java.io.Serializable; Line 4: import java.util.ArrayList; Line 5: import java.util.List; Line 29: } Line 30: Line 31: /* Line 32: * The value from vdsm should be in the format: Line 33: * 0:0,1:10240:9500 Add a very short explanation of the format. Something like: numa_node_id:cpu_list:total_memory:free_memory Line 34: * each field are separated by colon. Line 35: */ Line 36: public NumaNode(String value) { Line 37: if ((value != null) && (!value.trim().isEmpty())){ http://gerrit.ovirt.org/#/c/23702/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 87: private String iScsiInitiatorName; Line 88: Line 89: /* Line 90: * Refer to http://www.ovirt.org/Features/Detailed_NUMA_and_Virtual_NUMA Line 91: * for the format description Please put the description here, it does not matter that it is a bit longer. Line 92: */ Line 93: private String numa_nodes; Line 94: Line 95: private VdsTransparentHugePagesState transparentHugePagesState; Line 134: private java.util.HashSet<Version> _supportedClusterVersionsSet; Line 135: Line 136: private java.util.HashSet<Version> _supportedENGINESVersionsSet; Line 137: Line 138: private List<NumaNode> _numa_nodes_list; Please add a comment explaining that this is a cache that holds parsed representation of numa_nodes. Line 139: Line 140: /** Line 141: * This flag is set to true if the host PM can be controlled Line 142: * by policy. If a user triggered action puts the host -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
