Allon Mureinik has posted comments on this change. Change subject: core: Removing the use of getDisks from RestoreCommand ......................................................................
Patch Set 4: Code-Review+1 (3 comments) minor grammar comments on the commit message http://gerrit.ovirt.org/#/c/24054/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-02-05 12:20:45 +0200 Line 6: Line 7: core: Removing the use of getDisks from RestoreCommand Line 8: Line 9: I didn't found any place which initialize the disks in the s/I didn't found any/There is no/ s/which initialize/that initializes/ Line 10: parameter class when RestoreAllSnapshot was called. Line 11: Since there is no use of it what so ever, this patch removes the use of Line 12: it in the command, so we can decouple RestoreAllSnapshotsParameters from Line 13: TryBackToAllSnapshotsOfVmParameters Line 6: Line 7: core: Removing the use of getDisks from RestoreCommand Line 8: Line 9: I didn't found any place which initialize the disks in the Line 10: parameter class when RestoreAllSnapshot was called. s/was/is/ Line 11: Since there is no use of it what so ever, this patch removes the use of Line 12: it in the command, so we can decouple RestoreAllSnapshotsParameters from Line 13: TryBackToAllSnapshotsOfVmParameters Line 14: Line 7: core: Removing the use of getDisks from RestoreCommand Line 8: Line 9: I didn't found any place which initialize the disks in the Line 10: parameter class when RestoreAllSnapshot was called. Line 11: Since there is no use of it what so ever, this patch removes the use of s/what so ever/whatsoever/ Line 12: it in the command, so we can decouple RestoreAllSnapshotsParameters from Line 13: TryBackToAllSnapshotsOfVmParameters Line 14: Line 15: Change-Id: I1d0f5f92288ea92c114526e0d7d567a7ece45fbd -- To view, visit http://gerrit.ovirt.org/24054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d0f5f92288ea92c114526e0d7d567a7ece45fbd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
