Allon Mureinik has posted comments on this change. Change subject: engine: Add action type for snapshot. ......................................................................
Patch Set 15: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/20420/15//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-02-09 20:47:51 +0200 Line 6: Line 7: engine: Add action type for snapshot. Line 8: Line 9: The following patch changes the API between the client and the engine. in what flows? Line 10: The patch introduce the following changes: Line 11: * Adding an enum which distinguish between several operations on snapshot: Line 12: Undo Line 13: Commit Line 6: Line 7: engine: Add action type for snapshot. Line 8: Line 9: The following patch changes the API between the client and the engine. Line 10: The patch introduce the following changes: s/introduce/introduces/ Line 11: * Adding an enum which distinguish between several operations on snapshot: Line 12: Undo Line 13: Commit Line 14: Restore From Stateless status Line 7: engine: Add action type for snapshot. Line 8: Line 9: The following patch changes the API between the client and the engine. Line 10: The patch introduce the following changes: Line 11: * Adding an enum which distinguish between several operations on snapshot: s/distinguish/distinguishes/ s/on snapshot/on a snapshot/ Line 12: Undo Line 13: Commit Line 14: Restore From Stateless status Line 15: * Use of snapshot instead snapshotId http://gerrit.ovirt.org/#/c/20420/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java: Line 287: return typeName; Line 288: } Line 289: } Line 290: Line 291: public static enum SnapshotAction { This isn't coupled to the snapshot - it's an action I perform on it. I could want to either undo or commit the /same/ snapshot. this should be a top level class. Line 292: UNDO, Line 293: COMMIT, Line 294: RESTORE_STATELESS Line 295: } -- To view, visit http://gerrit.ovirt.org/20420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If877befc5058c3412ae3d3731d5beacbc09e5c97 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
