Eli Mesika has uploaded a new change for review. Change subject: core: Allow manual fence in connecting state ......................................................................
core: Allow manual fence in connecting state Allow to manually fence a Host that is in Connecting state. Up to now, when host had a network problem, it was switched to Connecting state for 3 attempts, after those attempts, if host was still unreachable, the host was turned to non-responding status. During the Connecting status, if you would try to manually fence the host, you would get an error saying: "Due to intermittent connectivity to this Host, fence operations are not allowed at this time. The system is trying to reconnect, please try again in 30 seconds." If an outage problem occurs, this limitation forces us to wait for all 3 network reconnect attempts before we can confirm that the host was rebooted and perform a manual fence (which can take several minutes) This patch removes this limitation and allow manually fencing a host that is in the Connecting state. Change-Id: I37a63d299244bc88a35e9c264e696ac88e6d7ef0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066400 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/24627/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java index 4a9cf09..711272a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java @@ -86,14 +86,8 @@ } } } else { - if (_problematicVds.getStatus() == VDSStatus.Connecting) { - returnValue = false; - addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VDS_INTERMITENT_CONNECTIVITY); - - } else { - returnValue = false; - addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VDS_NOT_MATCH_VALID_STATUS); - } + returnValue = false; + addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VDS_NOT_MATCH_VALID_STATUS); } return returnValue; } @@ -150,6 +144,7 @@ case NonResponsive: case Reboot: case Installing: + case Connecting: result = true; break; default: -- To view, visit http://gerrit.ovirt.org/24627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37a63d299244bc88a35e9c264e696ac88e6d7ef0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
