Michael Kublin has posted comments on this change. Change subject: core: Introducing another checkStatusAndLockVm method ......................................................................
Patch Set 2: I would prefer that you didn't submit this Sorry for -1, but concept is wrong, we should perform kind of following query: UODATE ... set status = locked where ... status != locked if update did not happens throw exception, a proposed code is not race safe -- To view, visit http://gerrit.ovirt.org/4457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93aacf0feb170aa990d25b30279a3e6f82cc0243 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
