Arik Hadas has posted comments on this change. Change subject: core: fix NPE when migration caused by maintenance fails ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24639/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java: Line 128: Step step = ExecutionHandler.addSubStep(getExecutionContext(), Line 129: parentContext.getJob().getStep(StepEnum.EXECUTING), Line 130: StepEnum.MIGRATE_VM, Line 131: ExecutionMessageDirector.resolveStepMessage(StepEnum.MIGRATE_VM, values)); Line 132: ctx.setJob(parentContext.getJob()); > its not enough that the job is set in the step (above)? where? in line 129 we don't set the job we just use it Line 133: ctx.setStep(step); Line 134: ctx.setMonitored(true); Line 135: } catch (RuntimeException e) { Line 136: log.error("Failed to create ExecutionContext for MigrateVmCommand", e); -- To view, visit http://gerrit.ovirt.org/24639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1bde265b078997507ad7f7e4b00fbd024cc3c39 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
