Gilad Chaplik has posted comments on this change. Change subject: core: resouces of VMs in launch state shouldn't be committed ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24651/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1862: int vmsCoresCount = 0; Line 1863: for (VM vm : _vmDict.values()) { Line 1864: // VMs' pending resources are cleared in powering up, so in launch state Line 1865: // we shouldn't include them as committed. Line 1866: if (!VMStatus.WaitForLaunch.equals(vm.getStatus())) { > it's more standard to compare them using != Done Line 1867: memCommited += vm.getVmMemSizeMb(); Line 1868: memCommited += _vds.getGuestOverhead(); Line 1869: vmsCoresCount += vm.getNumOfCpus(); Line 1870: } -- To view, visit http://gerrit.ovirt.org/24651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2db20c213ac326d620fad578bb5c1c78ff0b3bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
