Sergey Gotliv has posted comments on this change. Change subject: engine: Improve read-only disk validations ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24680/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-02-18 18:21:47 +0200 Line 6: Line 7: engine: Improve read-only disk validations Line 8: Line 9: 1. Validate that boot disk is read write. > 1. why? what if i have image(iso for example) on that disk? it's the user r I'll take your suggestion and replace block with the Audit log warnings. Line 10: 2. Allow edit read-only attribute of unplugged disk when VM is running. Line 11: 3. Create a single API that performs all read-only related validations. Line 12: Line 13: Change-Id: I36cdd4821168b529642f33e04fe9878183305b8e Line 6: Line 7: engine: Improve read-only disk validations Line 8: Line 9: 1. Validate that boot disk is read write. Line 10: 2. Allow edit read-only attribute of unplugged disk when VM is running. > perhaps will be clearer: Done Line 11: 3. Create a single API that performs all read-only related validations. Line 12: Line 13: Change-Id: I36cdd4821168b529642f33e04fe9878183305b8e Line 14: Bug-Url: https://bugzilla.redhat.com/1057658 -- To view, visit http://gerrit.ovirt.org/24680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36cdd4821168b529642f33e04fe9878183305b8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
