Liron Ar has posted comments on this change. Change subject: core: Add sp for getting vms/templates with attached disks on domain ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/23465/14/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java: Line 184: Line 185: /** Line 186: * Retrieves all ids of vms and templates that has image disks on the given domain Line 187: */ Line 188: List<Guid> getVmAndTemplatesIdsByStorageDomainId(Guid storageDomainId); > shouldn't it be added in VmDAO instead? as it returns both vms and templates ids, i decided to not have it on vm dao, what do you think? any better place? -- To view, visit http://gerrit.ovirt.org/23465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I918c540924961bf0ab99111a6d835c5a8211d20b Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
