Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: database: cast port to str
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/24788/1/packaging/setup/ovirt_engine_setup/database.py
File packaging/setup/ovirt_engine_setup/database.py:

Line 146:                     )
Line 147:                 else:
Line 148:                     _connection = connection = psycopg2.connect(
Line 149:                         host=host,
Line 150:                         port=str(port),
maybe a comment here for avoiding people to remove it?
Line 151:                         user=user,
Line 152:                         password=password,
Line 153:                         database=database,
Line 154:                         sslmode=sslmode,


-- 
To view, visit http://gerrit.ovirt.org/24788
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51476e7a07ae6bf475415329873c96ddea638686
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to