Yair Zaslavsky has posted comments on this change. Change subject: restapi : Allowing to use multiple storage domains via rest at Add vm with pools scenario ......................................................................
Patch Set 1: The general code (besides the missing tests) looks OK to me. However, don't you think that the scenario of constructing the map based on Disks will repeat itself in other API scenarios? Maybe you should extract it to a base class? -- To view, visit http://gerrit.ovirt.org/4460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865a9ad505c1910428da051aa89bd2b4f792fe87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
