Juan Hernandez has posted comments on this change.
Change subject: core: fix flow of FC DirectLUN disk creation
......................................................................
Patch Set 1: Verified+1 Code-Review+1
Just wanted to confirm that this works correctly from the RESTAPI:
# curl -k -X POST -H 'Accept: application/xml' -H 'Content-Type:
application/xml' -d '
<disk>
<alias>mylun</alias>
<format>raw</format>
<interface>virtio</interface>
<lun_storage>
<type>fcp</type>
<logical_unit id='\''0QEMU_QEMU_HARDDISK_drive-scsi0-0-1'\''/>
</lun_storage>
</disk>
' -u admin@internal:*** https://fedora.example.com/ovirt-engine/api/disks
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<disk href="/ovirt-engine/api/disks/0fe2a917-918b-42a7-bc97-51a23b01d1a0"
id="0fe2a917-918b-42a7-bc97-51a23b01d1a0">
<actions>
<link
href="/ovirt-engine/api/disks/0fe2a917-918b-42a7-bc97-51a23b01d1a0/export"
rel="export"/>
<link
href="/ovirt-engine/api/disks/0fe2a917-918b-42a7-bc97-51a23b01d1a0/move"
rel="move"/>
<link
href="/ovirt-engine/api/disks/0fe2a917-918b-42a7-bc97-51a23b01d1a0/copy"
rel="copy"/>
</actions>
<name>mylun</name>
<link
href="/ovirt-engine/api/disks/0fe2a917-918b-42a7-bc97-51a23b01d1a0/permissions"
rel="permissions"/>
<link
href="/ovirt-engine/api/disks/0fe2a917-918b-42a7-bc97-51a23b01d1a0/statistics"
rel="statistics"/>
<alias>mylun</alias>
<interface>virtio</interface>
<bootable>false</bootable>
<shareable>false</shareable>
<wipe_after_delete>false</wipe_after_delete>
<propagate_errors>false</propagate_errors>
<lun_storage id="0QEMU_QEMU_HARDDISK_drive-scsi0-0-1">
<logical_unit id="0QEMU_QEMU_HARDDISK_drive-scsi0-0-1">
<size>0</size>
<paths>0</paths>
<disk_id>0fe2a917-918b-42a7-bc97-51a23b01d1a0</disk_id>
</logical_unit>
</lun_storage>
</disk>
And with the command line, which is what was asked/requested to me:
# add disk --format raw --interface virtio --lun_storage-type fcp
--lun_storage-logical_unit
"logical_unit.id=0QEMU_QEMU_HARDDISK_drive-scsi0-0-1" --alias mylun
Thanks Daniel.
--
To view, visit http://gerrit.ovirt.org/24724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
