Alon Bar-Lev has posted comments on this change. Change subject: 3. [WIP] core: creating extension-manager module ......................................................................
Patch Set 8: (5 comments) http://gerrit.ovirt.org/#/c/24093/8/backend/manager/modules/authentication/pom.xml File backend/manager/modules/authentication/pom.xml: Line 22: <groupId>${engine.groupId}</groupId> Line 23: <artifactId>common</artifactId> Line 24: <version>${engine.version}</version> Line 25: </dependency> Line 26: deal Line 27: <dependency> Line 28: <groupId>${engine.groupId}</groupId> Line 29: <artifactId>extension-manager</artifactId> Line 30: <version>${engine.version}</version> Line 28: <groupId>${engine.groupId}</groupId> Line 29: <artifactId>extension-manager</artifactId> Line 30: <version>${engine.version}</version> Line 31: </dependency> Line 32: deal Line 33: Line 34: <dependency> Line 35: <groupId>org.jboss.spec.javax.servlet</groupId> Line 36: <artifactId>jboss-servlet-api_3.0_spec</artifactId> http://gerrit.ovirt.org/#/c/24093/8/backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileManager.java File backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticationProfileManager.java: Line 7: import org.ovirt.engine.core.extensions.mgr.Manager; Line 8: Line 9: Line 10: Line 11: extra spaces? Line 12: /** Line 13: * The authentication profile manager is responsible for managing a set of authentication profiles. Line 14: */ Line 15: public class AuthenticationProfileManager extends Manager<AuthenticationProfile> { http://gerrit.ovirt.org/#/c/24093/8/backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatorManager.java File backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/AuthenticatorManager.java: Line 5: import org.ovirt.engine.core.extensions.mgr.Configuration; Line 6: import org.ovirt.engine.core.extensions.mgr.Manager; Line 7: Line 8: Line 9: extra spaces? Line 10: /** Line 11: * The authenticator manager is responsible for managing a collection of authenticator objects. Line 12: */ Line 13: public class AuthenticatorManager extends Manager<Authenticator> { http://gerrit.ovirt.org/#/c/24093/8/frontend/webadmin/modules/gwt-extension/pom.xml File frontend/webadmin/modules/gwt-extension/pom.xml: Line 38: <artifactId>authentication</artifactId> Line 39: <version>${engine.version}</version> Line 40: <scope>provided</scope> Line 41: </dependency> Line 42: deal Line 43: <dependency> Line 44: <groupId>${engine.core.groupId}</groupId> Line 45: <artifactId>utils</artifactId> Line 46: <version>${engine.version}</version> -- To view, visit http://gerrit.ovirt.org/24093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c7258206880fd974934672de9fb5900192cca33 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
