Allon Mureinik has posted comments on this change. Change subject: core: GetAllVdsByStoragePoolQuery ......................................................................
Patch Set 6: Regarding renaming the parameter class: This is an anti-convention. Out of 132 query classes, only 20 have the word "Query" in their class name. Regarding removing the test: Don't like it, but I agree with your input. I'll remove it and upload a new patch. -- To view, visit http://gerrit.ovirt.org/4456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81c0bef83d0716a62ca6053023d2762403cd8523 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
