Martin Sivák has posted comments on this change. Change subject: Document the Agent FSM using docstrings and autogenerate the graphviz sources ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/24815/2/ovirt_hosted_engine_ha/agent/states.py File ovirt_hosted_engine_ha/agent/states.py: Line 259: :type fsm: BaseFSM Line 260: :type data: HostedEngineData Line 261: :type logger: logging.Logger Line 262: """ Line 263: return ReinitializeFSM(data), fsm.NOWAIT > ReinitializeFSM missing from the transition list above Done Line 264: Line 265: Line 266: class ReinitializeFSM(EngineState): Line 267: """ Line 489: :transition GlobalMaintenance: Line 490: :transition LocalMaintenance: Line 491: :transition UnknownLocalVmState: Line 492: :transition EngineForceStop: Line 493: :transition EngineStop: > nit: :transition: instead of :transition EngineStop: -- easier to parse if Done Line 494: :transition ReinitializeFSM: Line 495: """ Line 496: @check_global_maintenance(GlobalMaintenance) Line 497: @check_local_maintenance(LocalMaintenance) -- To view, visit http://gerrit.ovirt.org/24815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
