Hello Maor Lipchuk,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24846
to review the following change.
Change subject: core: Fix CDA message to include status
......................................................................
core: Fix CDA message to include status
Use format message correctly for Storage validation
Signed-off-by: Maor Lipchuk <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1067103
Bug-Url: https://bugzilla.redhat.com/1066838
Change-Id: I9620d167ec969ee6523829f0bd92fd1ca65f6b1f
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/24846/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
index 8283b33..e27aa02 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
@@ -37,7 +37,7 @@
}
if (storageDomain.getStatus() != StorageDomainStatus.Active) {
return new
ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL2,
- storageDomain.getStatus().name());
+ String.format("$%1$s %2$s", "status",
storageDomain.getStatus().name()));
}
return ValidationResult.VALID;
}
--
To view, visit http://gerrit.ovirt.org/24846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9620d167ec969ee6523829f0bd92fd1ca65f6b1f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
