Ravi Nori has posted comments on this change.

Change subject: cli: show command should retrieve sdk collection.get() method's 
args dynamically
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/24710/2/src/ovirtcli/shell/showcmdshell.py
File src/ovirtcli/shell/showcmdshell.py:

Line 53:         return AutoCompletionHelper.complete(line=line,
Line 54:                                              text=text,
Line 55:                                              args=args,
Line 56:                                              
specific_options=specific_options)
Line 57:     def is_show_argument(self, line, key):
> Ravi,
Hi Michael,

It is used in engineshell.py 

http://gerrit.ovirt.org/#/c/13023/11
Line 58:         args = TypeHelper.get_types_by_method(False, 
ShowCmdShell.ALIAS, expendNestedTypes=True)
Line 59:         if key in args:
Line 60:             return True
Line 61:         specific_options = self.get_resource_specific_options(args,


-- 
To view, visit http://gerrit.ovirt.org/24710
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9e0bce51f3a973049bffaa243aa1bd42e0ae25d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to