Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fix singleton of LdapQueryExecutionBuilderImpl ......................................................................
core: Fix singleton of LdapQueryExecutionBuilderImpl a. Remove static initialization b. Instance will be initialized on demand Change-Id: I7c8bfd1cef736518788a33cb0377a548afd3c831 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/24855/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java index 465ab1b..308f734 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapQueryExecutionBuilderImpl.java @@ -4,9 +4,16 @@ public class LdapQueryExecutionBuilderImpl implements LdapQueryExecutionBuilder { - private static LdapQueryExecutionBuilder instance; + private static volatile LdapQueryExecutionBuilder instance; public static LdapQueryExecutionBuilder getInstance() { + if (instance == null) { + synchronized (LdapQueryExecutionBuilderImpl.class) { + if (instance == null) { + instance = new LdapQueryExecutionBuilderImpl(); + } + } + } return instance; } @@ -16,9 +23,5 @@ LdapQueryMetadataFactoryImpl.getInstance().getLdapQueryMetadata(providerType, queryData); return queryMetadata.getFormatter().format(queryMetadata); - } - - static { - instance = new LdapQueryExecutionBuilderImpl(); } } -- To view, visit http://gerrit.ovirt.org/24855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c8bfd1cef736518788a33cb0377a548afd3c831 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
