Francesco Romani has posted comments on this change. Change subject: Implementation of logind based session locking ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24628/2/ovirt-guest-agent/LockActiveSession.py File ovirt-guest-agent/LockActiveSession.py: Line 89: break Line 90: session = None Line 91: except dbus.DBusException: Line 92: logging.exception("logind seems not to be available") Line 93: return session > Probably, but I don't think it's really worth it for this moment, they diff I see your point. I'm ok with this. Line 94: Line 95: Line 96: def GetActiveSession(): Line 97: bus = dbus.SystemBus() -- To view, visit http://gerrit.ovirt.org/24628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafc4b88d9c508647e1d09407556359fbefbba34c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
