Francesco Romani has posted comments on this change. Change subject: Implementation for CPU topology reporting ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23268/8/ovirt-guest-agent/topology.py File ovirt-guest-agent/topology.py: Line 33: Line 34: def _read_file(*parts): Line 35: f = open(os.path.join('/sys/devices/system/cpu', *parts), 'r') Line 36: result = f.read().replace('\n', '') Line 37: f.close() maybe try/finally to not leak a fd? (in admittedly extreme conditions) Line 38: return result Line 39: Line 40: Line 41: def _read_topology_file(id, file): -- To view, visit http://gerrit.ovirt.org/23268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If937fd33d2efa11425c814188df2087a85af8357 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
